Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIs: Don't output ? for empty queries #609

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Oct 29, 2020

Before:

julia> HTTP.URI(scheme="http", host="a.net", query=[]) |> string
"http://a.net?"

After:

julia> HTTP.URI(scheme="http", host="a.net", query=[]) |> string
"http://a.net"

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #609 into master will decrease coverage by 8.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   78.11%   69.40%   -8.71%     
==========================================
  Files          37       37              
  Lines        2435     1899     -536     
==========================================
- Hits         1902     1318     -584     
- Misses        533      581      +48     
Impacted Files Coverage Δ
src/URIs.jl 87.87% <100.00%> (-4.84%) ⬇️
src/status_messages.jl 1.21% <0.00%> (-97.57%) ⬇️
src/parseutils.jl 30.76% <0.00%> (-69.24%) ⬇️
src/IOExtras.jl 46.15% <0.00%> (-29.71%) ⬇️
src/debug.jl 13.04% <0.00%> (-23.33%) ⬇️
src/DebugRequest.jl 0.00% <0.00%> (-12.50%) ⬇️
src/Pairs.jl 55.55% <0.00%> (-11.12%) ⬇️
src/ConnectionPool.jl 68.80% <0.00%> (-8.83%) ⬇️
src/HTTP.jl 91.66% <0.00%> (-8.34%) ⬇️
src/layers.jl 91.66% <0.00%> (-8.34%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe162c...c277462. Read the comment docs.

@fonsp fonsp marked this pull request as ready for review October 29, 2020 11:21
@quinnj quinnj merged commit 70c7aa7 into JuliaWeb:master Oct 29, 2020
@quinnj
Copy link
Member

quinnj commented Oct 29, 2020

Thanks @fonsp! If you wouldn't mind, could you push this same change/test to https://github.com/JuliaWeb/URIs.jl? We're at a slightly awkward in-between state of splitting the URIs module out from HTTP.jl.

fonsp added a commit to fonsp/URIs.jl that referenced this pull request Oct 30, 2020
@fonsp fonsp deleted the patch-2 branch October 30, 2020 11:32
@fonsp
Copy link
Member Author

fonsp commented Oct 31, 2020

Sure! JuliaWeb/URIs.jl#5

c42f pushed a commit to JuliaWeb/URIs.jl that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants