Re-arrange error handling a bit #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't quite right. I'll fix it in the morning. |
If we did throw an error and tried to close the connection, there's no reason to try to do so again during the finally block. Also, if we are in the error block, close(io) has quite a high chance for failing, so wrap it in try to suppress such errors and instead rethrow the original error.
Closing the connection is a courtesy for the remote end, and one that is usually repayed by having the remote slam shut, which causes us to error. Don't propogate those errors to the user - instead only propagate errors from the read and the write end.
|
I've pushed another commit here that tries to propagate the correct error to the user. Before this, e.g. the AWS retry layer would get very mad at the random errors thrown by these close functions and just retry a request that failed for good reason. |
vtjnash
reviewed
Apr 15, 2020
| return r | ||
| catch e | ||
| @debug 1 "❗️ ConnectionLayer $e. Closing: $io" | ||
| try; close(io); catch; end |
There was a problem hiding this comment.
I think this is why we say close shouldn't error?
quinnj
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we did throw an error and tried to close the connection,
there's no reason to try to do so again during the finally block.
Also, if we are in the error block, close(io) has quite a high chance
for failing, so wrap it in try to suppress such errors and instead
rethrow the original error.