Allow any Associative as a header

[omus]

Allows alternative Dict types such as PyCall.PyDict to be used as a header.

[omus]

I could add some tests explicitly for this but most likely I would need to add a test requirement on DataStructures.jl to use an OrderedDict

[quinnj]

I wonder if we even leave off Associative here, as to allow for Vector{Pair}; then we could add tests w/ Vector{Pair} 😉

[samoconnor]

I have a WIP experimental branch where I've replaced the internal representation of the headers with a Vector{Pair}. This seems to work well and makes dealing with special cases rules (like Set-Cookie) easier.
samoconnor@bb120bd

[samoconnor]

@omus, mkheaders is now: mkheaders(h)::Headers = Header[string(k) => string(v) for (k,v) in h]
Does this cover the intention of your PR?

HTTP.jl/src/Messages.jl

Line 193 in e5d43cc

mkheaders(h)::Headers = Header[string(k) => string(v) for (k,v) in h]

[omus]

Looks like this is still an issue:

HTTP.jl/src/client.jl

Lines 39 to 45 in f9837eb

	function request(client::Client, method, url::URI;
	headers::Dict=Dict(),
	body="",
	enablechunked::Bool=true,
	stream::Bool=false,
	verbose::Bool=false,
	args...)

[samoconnor]

Sorry for the confusion, the request(client::Client, ... method is there for compatibility.
See commit b5844b1

The new doc says:

HTTP.jl/src/HTTP.jl

Lines 41 to 43 in f9837eb

	`headers` can be any collection where
	`[string(k) => string(v) for (k,v) in headers]` yields `Vector{Pair}`.
	e.g. a `Dict()`, a `Vector{Tuple}`, a `Vector{Pair}` or an iterator.

The top-level request method is now this:

HTTP.jl/src/HTTP.jl

Lines 293 to 301 in f9837eb

	function request(method, url, h=Header[], b=nobody;
	headers=h, body=b, query=nothing, kw...)::Response
	uri = URI(url)
	if query != nothing
	uri = merge(uri, query=query)
	end
	return request(string(method), uri, mkheaders(headers), body; kw...)
	end

mkheaders is now:

HTTP.jl/src/Messages.jl

Line 197 in f9837eb

mkheaders(h)::Headers = Header[string(k) => string(v) for (k,v) in h]

[omus]

Ah ok. If the headers keyword is now deprecated we should probably add a deprecation

[omus]

FYI I managed to make a small test to demonstrate the issue (It appears that not all PyDicts cause the issue)

julia> using HTTP, PyCall

julia> @pyimport requests

julia> r = requests.get("http://httpbin.org/xml")
PyObject <Response [200]>

julia> h = PyDict(r[:request][:headers])
PyCall.PyDict{PyCall.PyAny,PyCall.PyAny,false} with 4 entries:
  "Connection"      => "keep-alive"
  "Accept-Encoding" => "gzip, deflate"
  "Accept"          => "*/*"
  "User-Agent"      => "python-requests/2.18.4"

julia> HTTP.get("http://httpbin.org/xml", headers=h)
ERROR: TypeError: #request: in typeassert, expected Dict, got PyCall.PyDict{PyCall.PyAny,PyCall.PyAny,false}
Stacktrace:
 [1] (::HTTP.#kw##request)(::Array{Any,1}, ::HTTP.#request, ::HTTP.Client, ::String, ::HTTP.URIs.URI) at ./<missing>:0
 [2] #get#23(::Array{Any,1}, ::Function, ::String) at /Users/omus/.julia/v0.6/HTTP/src/client.jl:144
 [3] (::HTTP.#kw##get)(::Array{Any,1}, ::HTTP.#get, ::String) at ./<missing>:0

When I use the positional parameter the request works as expected:

julia> HTTP.get("http://httpbin.org/xml", h)
HTTP.Messages.Response:
"""
HTTP/1.1 200 OK
...
"""

[samoconnor]

Ah ok. If the headers keyword is now deprecated we should probably add a deprecation

No, its not deprecated:

HTTP.jl/src/HTTP.jl

Lines 293 to 294 in f9837eb

	function request(method, url, h=Header[], b=nobody;
	headers=h, body=b, query=nothing, kw...)::Response

Are you using latest master? This commit ought to fix that problem: b5844b1

[omus]

The keyword works on the latest master.

[omus]

Why do we support headers as a positional and keyword parameter? If this has been discussed elsewhere could you point me to the discussion?

[samoconnor]

#141 (comment)