Add test for parsing one charactar at a time, fix #125 and #126 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated PR with fix for #125 |
samoconnor
changed the title
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
===========================================
- Coverage 75.76% 39.19% -36.57%
===========================================
Files 15 15
Lines 2434 2396 -38
===========================================
- Hits 1844 939 -905
- Misses 590 1457 +867
Continue to review full report at Codecov.
|
|
updated with (failing) test for parsing requests 1 char at a time |
Replace local `KEY` in `parse!()` with `parser.previous_field`.
Add onurlbytes(). Accumulates URL in `parser.valuebuffer`.
Use `Ref{String}` to return `extra`/`upgrade` so that caller can tell
the difference between upgrade with empty string and no upgrade.
Add `s_req_fragment_start` to list of states where the url_mark should
be reset to 1.
samoconnor
changed the title
|
Updated with fix for #126 |
|
I'll need a few more days to review this; it touches several very low-level parts of the parser, so we want to be careful w/ performance and correctness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.