Fix error messages in @ require precondition testing macro #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a little hackery we can extract the function name from the internal `#self#` without the need to pattern match backtraces. Copies fixes from JuliaWeb/URIs.jl#33
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 76.84% 77.59% +0.75%
==========================================
Files 38 38
Lines 2513 2557 +44
==========================================
+ Hits 1931 1984 +53
+ Misses 582 573 -9
Continue to review full report at Codecov.
|
|
The test failures here seem due to the ongoing flakiness of the external websockets test host. |
fredrikekre
approved these changes
Sep 15, 2021
|
Yeah fair comment :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a little hackery we can extract the function name from the internal
#self#without the need to pattern match backtraces.Copies fixes from JuliaWeb/URIs.jl#33