Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name occurences #51

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix name occurences #51

merged 1 commit into from
Apr 29, 2021

Conversation

Arkoniak
Copy link
Collaborator

It turns out that MaxMind db stores data in a directory, so naive equality fails.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #51 (0fabaaf) into master (006b63a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files           2        2           
  Lines          74       74           
=======================================
  Hits           65       65           
  Misses          9        9           
Impacted Files Coverage Δ
src/data.jl 87.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 006b63a...0fabaaf. Read the comment docs.

@Arkoniak Arkoniak merged commit 66cc4a7 into JuliaWeb:master Apr 29, 2021
@Arkoniak Arkoniak deleted the fix_load branch April 29, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants