Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to julia1 #39

Merged
merged 7 commits into from
Mar 23, 2021
Merged

Conversation

Arkoniak
Copy link
Collaborator

This PR includes:

  1. load procedure update. It can now download data locally (remote download is broken, due to the maxmind policy).
  2. geolocation procedure fix. Now noupdate means, that all update checks are skipped.

@Arkoniak Arkoniak force-pushed the upgrading_to_julia1 branch from 6c7e518 to a918785 Compare March 23, 2021 13:30
@Arkoniak
Copy link
Collaborator Author

Closes #12

@Arkoniak Arkoniak linked an issue Mar 23, 2021 that may be closed by this pull request
@Arkoniak Arkoniak linked an issue Mar 23, 2021 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #39 (363c955) into master (1df1beb) will increase coverage by 43.03%.
The diff coverage is 63.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #39       +/-   ##
===========================================
+ Coverage    0.00%   43.03%   +43.03%     
===========================================
  Files           2        3        +1     
  Lines          82       79        -3     
===========================================
+ Hits            0       34       +34     
+ Misses         82       45       -37     
Impacted Files Coverage Δ
src/GeoIP.jl 100.00% <ø> (ø)
src/geoip-module.jl 69.56% <60.00%> (+69.56%) ⬆️
src/data.jl 30.90% <65.00%> (+30.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df1beb...363c955. Read the comment docs.

@Arkoniak Arkoniak mentioned this pull request Mar 23, 2021
@Arkoniak Arkoniak linked an issue Mar 23, 2021 that may be closed by this pull request
@Arkoniak
Copy link
Collaborator Author

Closes #40

@Arkoniak Arkoniak linked an issue Mar 23, 2021 that may be closed by this pull request
@Arkoniak Arkoniak merged commit ddf4126 into JuliaWeb:master Mar 23, 2021
@Arkoniak Arkoniak deleted the upgrading_to_julia1 branch March 23, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants