Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dataframes #24

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Update Dataframes #24

merged 2 commits into from
Mar 16, 2018

Conversation

nsmith5
Copy link

@nsmith5 nsmith5 commented Mar 15, 2018

Fixes #23. Uses CSV.read to replace the, now deprecated, DataFrames.readtable.

@nsmith5 nsmith5 requested a review from randyzwitch March 15, 2018 20:00
@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #24 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   90.27%   90.54%   +0.26%     
==========================================
  Files           2        2              
  Lines          72       74       +2     
==========================================
+ Hits           65       67       +2     
  Misses          7        7
Impacted Files Coverage Δ
src/data.jl 91.83% <100%> (+0.34%) ⬆️
src/geoip-module.jl 88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5fbe9...8650c1d. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage increased (+0.3%) to 90.541% when pulling 8650c1d on nsmith5:update-dataframes into 9f5fbe9 on JuliaWeb:master.

@nsmith5
Copy link
Author

nsmith5 commented Mar 15, 2018

Probably a good idea to tag a new release after this. 0.2.x makes sense to me because the API hasn't changed at all just deprecation of older Julia versions.

@randyzwitch randyzwitch merged commit 5f078e9 into JuliaWeb:master Mar 16, 2018
@randyzwitch
Copy link
Contributor

LGTM. I'll tag a new version.

@nsmith5 nsmith5 deleted the update-dataframes branch March 16, 2018 16:25
@nsmith5
Copy link
Author

nsmith5 commented Mar 16, 2018

I deleted and created the release again to trigger attobot. Hopefully our PR on METADATA will succeed this time..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants