Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

88 fix docstrings #89

Merged
merged 4 commits into from
May 29, 2024
Merged

88 fix docstrings #89

merged 4 commits into from
May 29, 2024

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented May 29, 2024

No description provided.

@pat-alt pat-alt linked an issue May 29, 2024 that may be closed by this pull request
@pat-alt pat-alt requested a review from pasq-cat May 29, 2024 08:51
@pat-alt
Copy link
Member Author

pat-alt commented May 29, 2024

@Rockdeldiablo to see. This PR

  • improves the docstrings as discussed
  • adds a CHANGELOG.md
  • removes the redundant method overload

With respect to your ongoing work it is worth considering if what we need for conformal Bayes is just the GLM prediction (predicted mean and variance). In that case, I think our MLJFlux interface should use glm_predictive_distribution by default.

In the regression case, this is what is returned anyway when calling predict. In the classification case, the predict method just applies probit approximation (unless :plugin was specified) and optionally passes linear predictions through sigmoid/softmax.

@pasq-cat
Copy link
Member

ok, i think i have understood.

@pasq-cat pasq-cat merged commit 00bdfc2 into main May 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docstrings
2 participants