Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gradient and jacobians as multi-dimensional arrays #20

Closed
Tracked by #25
pat-alt opened this issue Nov 25, 2022 · 2 comments
Closed
Tracked by #25

Refactor gradient and jacobians as multi-dimensional arrays #20

pat-alt opened this issue Nov 25, 2022 · 2 comments
Assignees
@pat-alt
Labels
enhancement New feature or request medium This is expected to be medium. students 🎯 A label indicating that this issue is an expected feature for the student software project.

Comments

@pat-alt
Copy link
Member

pat-alt commented Nov 25, 2022 •
edited
Loading

This is an issue reserved for the TU Delft Student Software Project '23 - LaplaceRedux

I think this is a fairly challenging problem, so do expect to spend some time on this. It may involve some breaking changes to the core architecture of the package, but on the bright side, it should help with some outstanding issues.

Currently gradients and Jacobians are mapped to two-dimensional arrays, since so far I had not considered training LA in batches (see related #19). This currently leads to problems for the implementation of GGN for the multi-class cases (see related #17). Refactoring things properly should help. In this context it may be worth using Tullio.jl for multi-dimensional array computations.
@pat-alt pat-alt added enhancement New feature or request medium This is expected to be medium. labels Nov 25, 2022
This was referenced Nov 25, 2022
Closed
Closed
@pat-alt
Copy link
Member Author

pat-alt commented Nov 25, 2022

Check here for a good reference on Einstein summation.

@pat-alt pat-alt self-assigned this Nov 29, 2022
pat-alt added a commit that referenced this issue Dec 10, 2022
@pat-alt
added assertion error for mutli-class, will fix after #20 is fixed
dfc9f15
@pat-alt pat-alt mentioned this issue Jan 27, 2023
Closed
This was referenced Apr 13, 2023
Closed
Closed
@pat-alt pat-alt added the students 🎯 A label indicating that this issue is an expected feature for the student software project. label Apr 13, 2023
@severinbratus severinbratus mentioned this issue Jun 22, 2023
Merged
severinbratus pushed a commit that referenced this issue Jul 5, 2023
@navimakarov
Merge pull request #20 from navimakarov/1-multi-class-problems
33694cd 
Fix Multi-Class Posterior Prediction Issue
@pat-alt
Copy link
Member Author

pat-alt commented Jul 6, 2023

closed by #33

@pat-alt pat-alt closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat-alt pat-alt

Labels
enhancement New feature or request medium This is expected to be medium. students 🎯 A label indicating that this issue is an expected feature for the student software project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pat-alt