Skip to content

Commit

Permalink
Merge pull request #105 from JuliaTrustworthyAI/104-fix-compat-issue
Browse files Browse the repository at this point in the history
done?
  • Loading branch information
pat-alt authored Jul 22, 2024
2 parents 26c19db + 0f15621 commit 5ab4bd1
Show file tree
Hide file tree
Showing 2 changed files with 145 additions and 111 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ComputationalResources = "0.3.2"
Distributions = "0.25.109"
Flux = "0.12, 0.13, 0.14"
LinearAlgebra = "1.7, 1.10"
MLJBase = "0, 1.4.0"
MLJBase = "< 1.4.0"
MLJFlux = "0.5"
MLJModelInterface = "1.8.0"
MLUtils = "0.4"
Expand Down
Loading

3 comments on commit 5ab4bd1

@pat-alt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/111486

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.0 -m "<description of version>" 5ab4bd1d47ad4ddfe449c464253ddb2b924db02b
git push origin v1.0.0

@pasq-cat
Copy link
Member

@pasq-cat pasq-cat commented on 5ab4bd1 Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pat-alt despite the use of julia registrator, the version is still 0.2.

i think i need to apply the tag and draft a new release but i am not sure where to write the the piece of code written in the previous message. copy-pasted the code in git bash for main and it doesn't seem to have done anything. update: nvm i think i solved it. i made a new release.

Please sign in to comment.