Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancing gradients #492

Merged
merged 13 commits into from
Nov 7, 2024

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Oct 30, 2024

Observations

@pat-alt pat-alt linked an issue Oct 30, 2024 that may be closed by this pull request
@pat-alt pat-alt marked this pull request as ready for review October 30, 2024 07:56
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.52%. Comparing base (9013ce1) to head (719ca82).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/convergence/generator_conditions.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   90.48%   90.52%   +0.03%     
==========================================
  Files          91       91              
  Lines        1966     1973       +7     
==========================================
+ Hits         1779     1786       +7     
  Misses        187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-alt pat-alt merged commit 3a8cdc3 into main Nov 7, 2024
9 checks passed
@pat-alt pat-alt mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Gradient Magnitude Matching or Root Scaling Sort out PROBE
1 participant