Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 wrap models predict interval #14

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Oct 17, 2022

Addressed type piracy issue. Now using a separate method predict_region to compute conformal prediction regions, while the generic predict computes point predictions as always. It probably makes sense to make that distinction explicit, because:

  • I'm not sure how/if set-valued/interval predictions fit easily into the standard MLJ paradigm (probably not).
  • Even if there was a way to make that work, I'm no longer sure that's even desirable. For any model that has been calibrated for conformal prediction, you can always still also produce point predictions. So it seems reasonable to preserve that functionality and treat conformal prediction as a separate functionality.

CompatHelper Julia and others added 7 commits October 16, 2022 00:28
…16-00-28-14-369-01519471332

CompatHelper: add new compat entry for MLJBase at version 0.20, (keep existing compat)
…16-00-28-06-826-04168995648

CompatHelper: add new compat entry for MLJModelInterface at version 1, (keep existing compat)
@pat-alt pat-alt merged commit 9820a71 into develop Oct 17, 2022
@pat-alt pat-alt deleted the 5-wrap-models-predict-interval branch October 17, 2022 07:45
@pat-alt pat-alt mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant