Adding support for DecisionTree.jl models. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @john-waczak, thanks very much for this! Reformatting has been a bit of a pain point, so if this see resolves the issue should also have better compatibility with other models from |
|
Awesome, I've really enjoyed using the package so far. Thank you for the hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for models from
DecisionTree.jl. Specifically, I have tested:DecisionTreeRegressorRandomForestRegressorDecisionTreeClassifierRandomForestClassifierTo get this to work, I had to move the calls to
MMI.reformat(conf_model.model, ...)to inside thefitandpredictmethods. CallingMMI.reformat()on data before passing tofitandpredictcauses these models to fail, perhaps due to this issue.