Added extra FixedTimeZones #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some coverage for fixed.jl. Currently the file has no testcases that use the |
All of the fixed timezones that were added can be found in the file
"etcetera" from the IANA website. Even though we could support these
timezones I think we shouldn't as they are deemed historical along with
"backward".
Additionally, the "Etc/GMT(+|-)\d+" can be confusing as their labels
("GMT+1") have the opposite offset (-3600 seconds).
See ftp://ftp.iana.org/tz/data/etcetera for details.
|
I've decided that the "Etc/..." timezones are historical and shouldn't be used. For those who want to use something like them try I've added some notes into build.jl which acknowledges the existence of the "etcetera" file. The only new TimeZones added by this PR are: "UTC" and "GMT". |
omus
pushed a commit
to invenia/TimeZones.jl
that referenced
this pull request
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for some common fixed time zones