Avoid overriding the windowsZone.xml file #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows downloading a new windowsZone.xml file would override the committed the committed file causing the package to be dirty. Code has been updated to download a new windowsZone.xml file to a temporary location and we can fall back to the committed file.
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 19 19
Lines 798 798
=======================================
Hits 726 726
Misses 72 72Continue to review full report at Codecov.
|
|
This is going to keep downloading new copies every time Pkg.build runs, and never clean them up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows downloading a new windowsZone.xml file would override the committed the committed file causing the package to be dirty. Code has been updated to download a new windowsZone.xml file to a temporary location and we can fall back to the committed file.
Originally pointed out by @tkelman JuliaLang/METADATA.jl#8378 (comment)