Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #189

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Documentation update #189

merged 4 commits into from
Mar 28, 2019

Conversation

omus
Copy link
Member

@omus omus commented Mar 28, 2019

  • Adds API documentation
  • Updates Documenter to 0.22
  • Correct broken links

Note that one of the broken links was an issue with the Julia documentation: JuliaLang/julia#31484

@omus omus requested a review from iamed2 March 28, 2019 15:04
@oxinabox
Copy link
Contributor

Should a docs/Manifest.toml be checked into the repo?

@iamed2
Copy link
Member

iamed2 commented Mar 28, 2019

Approval pending docs manifest

@omus
Copy link
Member Author

omus commented Mar 28, 2019

Should a docs/Manifest.toml be checked into the repo?

Yes I should.

@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

Merging #189 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage    91.2%   91.68%   +0.47%     
==========================================
  Files          30       30              
  Lines        1058     1058              
==========================================
+ Hits          965      970       +5     
+ Misses         93       88       -5
Impacted Files Coverage Δ
src/local.jl 91.89% <ø> (ø) ⬆️
src/tzfile.jl 95.58% <ø> (ø) ⬆️
src/winzone/WindowsTimeZoneIDs.jl 90% <0%> (+5%) ⬆️
src/tzdata/build.jl 70% <0%> (+6.66%) ⬆️
src/tzdata/archive.jl 92.59% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a2edd...d54e21a. Read the comment docs.

@omus omus merged commit 92abbc5 into master Mar 28, 2019
@omus omus deleted the cv/docs-update branch March 28, 2019 20:52
kpamnany pushed a commit to RelationalAI-oss/TimeZones.jl that referenced this pull request May 5, 2023
* Add API documentation

* Docs deploy script uses make.jl

* Update to Documenter 0.22

* Add docs/Manifest.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants