use ShortString for VariableTimeZone name

JuliaTime · Apr 14, 2021 · d2fdec9 · d2fdec9
1 parent 7ba4d85
commit d2fdec9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -18,7 +18,7 @@ Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"
 EzXML = "0.9.1, 1"
 Mocking = "0.7"
 RecipesBase = "0.7, 0.8, 1"
-ShortStrings = "0.3.6"
+ShortStrings = "0.3.7"
 julia = "1"
 
 [extras]

diff --git a/src/TimeZones.jl b/src/TimeZones.jl
@@ -4,7 +4,7 @@ using Dates
 using Printf
 using Serialization
 using RecipesBase: RecipesBase, @recipe
-using ShortStrings: ShortString15
+using ShortStrings: ShortString15, ShortString63
 using Unicode
 
 import Dates: TimeZone, UTC

diff --git a/src/types/variabletimezone.jl b/src/types/variabletimezone.jl
@@ -5,13 +5,17 @@ end
 
 Base.isless(a::Transition, b::Transition) = isless(a.utc_datetime, b.utc_datetime)
 
+# Ideally would always use ShortString63, but it's `hash` is broken on 32-bit systems.
+# https://github.com/JuliaString/MurmurHash3.jl/issues/12
+const VariableZoneName = Int === Int64 ? ShortString63 : String
+
 """
     VariableTimeZone
 
 A `TimeZone` with an offset that changes over time.
 """
 struct VariableTimeZone <: TimeZone
-    name::String
+    name::VariableZoneName
     transitions::Vector{Transition}
     cutoff::Union{DateTime,Nothing}