Lower write version

JuliaTime · Jun 17, 2022 · 4ed324b · 4ed324b
1 parent 28970ab
commit 4ed324b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/tzfile/TZFile.jl b/src/tzfile/TZFile.jl
@@ -7,7 +7,9 @@ using Dates: Dates, DateTime, Second, datetime2unix, unix2datetime
 using ...TimeZones: FixedTimeZone, VariableTimeZone, Transition, isdst
 
 const SUPPORTED_VERSIONS = ('\0', '1', '2', '3', '4')
-const LATEST_VERSION = last(SUPPORTED_VERSIONS)
+
+# Writers should generate the lowest version number needed by the data
+const WRITE_VERSION = '2'
 
 include("utils.jl")
 include("read.jl")

diff --git a/src/tzfile/write.jl b/src/tzfile/write.jl
@@ -39,7 +39,7 @@ function _combine_designations(abbrs::AbstractVector{<:AbstractString})
     return result, indices
 end
 
-function write(io::IO, tz::FixedTimeZone; version::Char=LATEST_VERSION)
+function write(io::IO, tz::FixedTimeZone; version::Char=WRITE_VERSION)
     combined_designation, designation_indices = combine_designations([tz.name])
 
     transition_times = Vector{Int32}()
@@ -63,7 +63,7 @@ function write(io::IO, tz::FixedTimeZone; version::Char=LATEST_VERSION)
     end
 end
 
-function write(io::IO, tz::VariableTimeZone; version::Char=LATEST_VERSION)
+function write(io::IO, tz::VariableTimeZone; version::Char=WRITE_VERSION)
     combined_designation, designation_indices = combine_designations(t.zone.name for t in tz.transitions)
 
     function compatible_transition(t::Transition)