Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding initial data for Kaqchikel Maya Language #43

Merged
merged 2 commits into from
May 22, 2023

Conversation

Chok-Ketzamtzib
Copy link
Contributor

I would like to add this under-resourced language for my NLP project and to contribute to the JuliaText ecosystem.

@aviks aviks merged commit d96adf2 into JuliaText:master May 22, 2023
@aviks
Copy link
Member

aviks commented May 22, 2023

I merged this thinking that the test failures are unrelated, but that was wrong. The test failure is due to the existing language detection tests now being confused between Ilocano and Kaqchikel. Wondering what can we do here.

@aviks
Copy link
Member

aviks commented May 22, 2023

Hi @Chok-Ketzamtzib so every language in test/example.json is used in a language detection test. For that functionality to work, a set of top trigrams for the language must be added to data/data.json . If you can generate that, that'll be good. Otherwise, for the moment, I'll remove cak from examples.json.

@Chok-Ketzamtzib
Copy link
Contributor Author

I will update later tonight after work. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants