-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Paragram Embedding #30
Conversation
I made a prototype of this a few years back. It would be nice to see something more polished. I agree that it doesn't belong here. |
For now, I don't need it for any project but would love to find a home to code. |
I suggest you create a GoogleDrive.jl package, Register that package, then we will add it as a dependency of Embeddings.jl |
Hi @oxinabox I created GoogleDrive.jl Package , and also opened a Registration PR |
@oxinabox as suggested GoogleDrive.jl as dependency and common.jl is added |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 96.77% 95.95% -0.82%
==========================================
Files 4 6 +2
Lines 93 99 +6
==========================================
+ Hits 90 95 +5
- Misses 3 4 +1
Continue to review full report at Codecov.
|
src/common.jl
Outdated
@@ -0,0 +1,28 @@ | |||
|
|||
function _load_embeddings_csv( embedding_file, max_vocab_size, keep_words) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also use this for FastText maybe? there is at least some code overlap.
Might need to factor out the common inner parts.
We should probably not call it a CSV since it is space seperated,
Or we call it a CSV and pass in a deliminator option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deliminator option is added as suggested
Co-Authored-By: Lyndon White <[email protected]>
Co-Authored-By: Lyndon White <[email protected]>
Co-Authored-By: Lyndon White <[email protected]>
thanks |
Hi @oxinabox , |
I am adding Paragram Embedding and Google-drive download fetch method for datadeps in Paragram.I think it will be great to have default G-drive download fetch method in Datadeps