Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only split on spaces only in Glove, not any whitespace fixes #24 #26

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

oxinabox
Copy link
Member

Fixes #24

Turns out Julia split(str) splits on nonbreaking spaces.
We only need to split on spaces.

Before this can be merged:

  • Project.toml need to be added
  • CI updated for 1.0+
  • Tests may need to be added if the were not already catching this (and being ignored for some other reason.)

@oxinabox oxinabox mentioned this pull request Nov 15, 2019
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #26 into master will decrease coverage by 2.11%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   98.88%   96.77%   -2.12%     
==========================================
  Files           4        4              
  Lines          90       93       +3     
==========================================
+ Hits           89       90       +1     
- Misses          1        3       +2
Impacted Files Coverage Δ
src/glove.jl 92% <60%> (-8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5598cf3...fa05da9. Read the comment docs.

@oxinabox oxinabox merged commit 6232141 into master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems loading glove.840B.300d/glove.840B.300d.txt (GloVe{:en}, 6)
2 participants