Skip to content

Commit

Permalink
Merge pull request #28 from JuliaText/de/keepwords
Browse files Browse the repository at this point in the history
make sure keep_words is a set
  • Loading branch information
oxinabox authored Nov 22, 2019
2 parents 6232141 + e2dad12 commit 65390f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Embeddings"
uuid = "c5bfea45-b7f1-5224-a596-15500f5db411"
authors = ["Lyndon White"]
version = "0.4.0"
version = "0.4.1"

[deps]
AutoHashEquals = "15f4f7f2-30c1-5605-9d31-71845cf9641f"
Expand Down
2 changes: 1 addition & 1 deletion src/Embeddings.jl
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function load_embeddings(::Type{T},
max_vocab_size=typemax(Int),
keep_words=Set()) where T<:EmbeddingSystem

EmbeddingTable(_load_embeddings(T, embedding_file, max_vocab_size, keep_words)...)
EmbeddingTable(_load_embeddings(T, embedding_file, max_vocab_size, Set(keep_words))...)
end

end

2 comments on commit 65390f1

@oxinabox
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/5736

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.1 -m "<description of version>" 65390f14e4903dfc767548a73b40b7e40a2e0358
git push origin v0.4.1

Please sign in to comment.