Get TestSet kwargs working #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 96.24% 96.14% -0.11%
==========================================
Files 7 7
Lines 533 545 +12
==========================================
+ Hits 513 524 +11
- Misses 20 21 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oxinabox
reviewed
Apr 12, 2023
| for r in ts_default.results | ||
| r isa AbstractTestSet && finish(r) | ||
| end | ||
| catch err |
There was a problem hiding this comment.
Should the try-catch be inside the for loop?
There was a problem hiding this comment.
Although that would display more results, it's not how Pkg.test would display the results (that is if first testset of a package fails then the second one wouldn't be displayed as an error is thrown when the first testset finishes. So will keep it as is for now
oxinabox
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes an issue where all errors were being hidden when
finishwas being applied to display the results.Second commit enables
showtimeandverbosekwargs to be used in package tests and the displayed output (indisplay_reporting_testset) updated to ensure correct test timings are displayed and that the kwargs have the intended effect.Closes #90 .