Use Pass info in v1.7 and later #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 96.92% 91.84% -5.08%
==========================================
Files 7 7
Lines 520 552 +32
==========================================
+ Hits 504 507 +3
- Misses 16 45 +29
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Just needs updating docs. |
|
@oxinabox ping. Would love to have it for our repo. |
oxinabox
approved these changes
Mar 24, 2022
src/to_xml.jl
Outdated
| @@ -199,7 +199,8 @@ function to_xml(ts::AbstractTestSet) | |||
| set_attribute!(x_testcase, "classname", ts.description) | |||
| set_attribute!(x_testcase, "time", time_taken(result)::Millisecond) | |||
| # Set attributes which require variables in this scope | |||
| (result isa Pass || result isa ReportingResult{Pass}) && set_attribute!(x_testcase, "name", x_testcase["name"] * " (Test $total_ntests)") | |||
| ntests > 0 && set_attribute!(x_testcase, "id", total_ntests) # Ignore both testsuites and errors outside of tests | |||
| (result isa Pass || result isa ReportingResult{Pass}) && VERSION < v"1.7.0" && set_attribute!(x_testcase, "name", x_testcase["name"] * " (Test $total_ntests)") | |||
There was a problem hiding this comment.
Should we introduce a ispass(result) function that covers both these?
added 2 commits
March 30, 2022 07:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the original expression is the best thing to use for
testname, and thought we may as well keep using the count in theidfield as this also closes #62.Closes #77
EDIT: okay it ended up being a bit more of a change, and it changes test case
IDs andnames so I have made it a breaking change. Now all passes, failures and errors (except for errors outside of tests) have theidset to a number which increments per testset. ForPasses, thenameis the original test expression forv1.7.0and above; andpass (info lost) (Test 1)is the name belowv.1.7.0.