Refactor runner.jl #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
===========================================
+ Coverage 99.68% 100.00% +0.31%
===========================================
Files 5 5
Lines 319 322 +3
===========================================
+ Hits 318 322 +4
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
oxinabox
approved these changes
Dec 30, 2020
src/runner.jl
Outdated
| julia_args::Union{Cmd, AbstractVector{<:AbstractString}}=``, | ||
| test_args::Union{Cmd, AbstractVector{<:AbstractString}}=``) | ||
|
|
||
| Tests `pkg` and save report to `logfilename`. Unit tests are run in the same way |
There was a problem hiding this comment.
Suggested change
| Tests `pkg` and save report to `logfilename`. Unit tests are run in the same way | |
| Tests `pkg` and save report to `logfilename`. Tests are run in the same way |
They might be unit tests they might not..doesn't matter to us
There was a problem hiding this comment.
Good point, think I've said unit elsewhere too so will go and check
mmiller-max
force-pushed
the
mm/tidy-runner
branch
from
dbc28e0 to
76cf771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test!a bit smaller by splitting some functionality into functionsPart of #48