Improve dryrun #17
Merged
Improve dryrun #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were giving up when e.g. a description couldn't be eval'ed, without printing children. Also, we indicate when a testset is supposed to be repeated, whether when we don't know how many times (e.g. couldn't eval the length of testset-for iterator), or when the testset-for description is a String (doesn't depend on loop variables).
Also, don't warn anymore from resolve! : it was insufficient (didn't show the line number), and it seems better to rely on dryrun for detecting that (and adding yet another flag to not be warned is annoying).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.