implement ambiguity hint #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 73.05% 73.66% +0.60%
==========================================
Files 10 10
Lines 605 619 +14
==========================================
+ Hits 442 456 +14
Misses 163 163
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
bump @tkf |
|
Thanks for the ping! |
|
Registering JuliaRegistries/General#55764 |
giordano
reviewed
Mar 24, 2022
| sigfix = typeintersect(m2.sig, sigfix) | ||
| if isa(Base.unwrap_unionall(sigfix), DataType) && sigfix <: Tuple | ||
| let sigfix = sigfix | ||
| if all(m->Base.morespecific(sigfix, m.sig), [m1, m2]) |
There was a problem hiding this comment.
This broke Julia v1.0-1.3:
julia> Base.morespecific
ERROR: UndefVarError: morespecific not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #52