Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test_piracy to test_piracies? #228

Closed
hyrodium opened this issue Oct 31, 2023 · 4 comments · Fixed by #230
Closed

Rename test_piracy to test_piracies? #228

hyrodium opened this issue Oct 31, 2023 · 4 comments · Fixed by #230
Labels

Comments

@hyrodium
Copy link
Contributor

As I mentioned in #88 (comment), I believe it would be more consistent to rename the test_picary function to test_piracies, similar to how we have test_ambiguities.

@lgoettgens
Copy link
Collaborator

I have no opinion on this.

But since this would be a breaking change, now (before the upcoming 0.8.0 release) would be a good time to do such a change.

@hyrodium
Copy link
Contributor Author

Should we deprecate with @deprecate test_piracy test_piracies and release v0.7.5?
Or, can I make a PR to rename the function without deprecation?

@lgoettgens
Copy link
Collaborator

You can add a PR without deprecation to be released as part of 0.8.0 (if @fingolfin doesn't object)

@fingolfin
Copy link
Member

I personally think this is pointless busywork, but as long as someone else does it and it doesn't cause me any extra work, I won't object :-)

Sbozzolo added a commit to CliMA/ClimaCore.jl that referenced this issue Nov 16, 2023
Sbozzolo added a commit to CliMA/ClimaAtmos.jl that referenced this issue Nov 16, 2023
Sbozzolo added a commit to CliMA/ClimaAtmos.jl that referenced this issue Nov 16, 2023
Sbozzolo added a commit to CliMA/ClimaAtmos.jl that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants