-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename test_piracy
to test_piracies
?
#228
Comments
I have no opinion on this. But since this would be a breaking change, now (before the upcoming 0.8.0 release) would be a good time to do such a change. |
Should we deprecate with |
You can add a PR without deprecation to be released as part of 0.8.0 (if @fingolfin doesn't object) |
I personally think this is pointless busywork, but as long as someone else does it and it doesn't cause me any extra work, I won't object :-) |
As I mentioned in #88 (comment), I believe it would be more consistent to rename the
test_picary
function totest_piracies
, similar to how we havetest_ambiguities
.The text was updated successfully, but these errors were encountered: