Skip to content

Commit

Permalink
Fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens committed Oct 17, 2023
1 parent 543a73a commit ac007e1
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
22 changes: 14 additions & 8 deletions test/test_deps_compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ const DictSA = Dict{String,Any}
"deps",
)
@test isempty(result)
result = find_missing_deps_compat(
DictSA(
"deps" => DictSA("SHA" => "ea8e919c-243c-51af-8825-aaa63cd721ce"),
"compat" => DictSA("julia" => "1"),
),
"deps",
)
@test isempty(result)
result = find_missing_deps_compat(
DictSA(
"deps" => DictSA("PkgA" => "229717a1-0d13-4dfb-ba8f-049672e31205"),
Expand Down Expand Up @@ -69,6 +61,20 @@ const DictSA = Dict{String,Any}
@test length(result) == 1
@test [pkg.name for pkg in result] == ["PkgB"]
end

@testset "does not specify `compat` for stdlib" begin
result = find_missing_deps_compat(
DictSA(
"deps" => DictSA(
"LinearAlgebra" => "37e2e46d-f89d-539d-b4ee-838fcccc9c8e",
),
"compat" => DictSA("julia" => "1"),
),
"deps",
)
@test length(result) == 1
@test [pkg.name for pkg in result] == ["LinearAlgebra"]
end
end
end

Expand Down
1 change: 1 addition & 0 deletions test/test_smoke.jl
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ using Aqua
Aqua.test_all(
Aqua;
stale_deps = (; ignore = [:Compat]), # conditionally loaded
deps_compat = VERSION <= v"1.3-" ? (; ignore = [:Test]) : true,
)

# test everything else
Expand Down

0 comments on commit ac007e1

Please sign in to comment.