Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legendentry for Barchart and Scatter (#182) #183

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix legendentry for Barchart and Scatter (#182) #183

merged 1 commit into from
Mar 7, 2022

Conversation

johannes-fischer
Copy link
Contributor

This fixes #182:

  • BarChart was missing the plotLegend call.
  • An array of legend entries can now be provided at once, this should make the scatter example from the docs working.

An array of legendentries can be provided at once now.
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #183 (35098e4) into master (7207ce9) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   63.36%   63.34%   -0.03%     
==========================================
  Files           5        5              
  Lines         797      802       +5     
==========================================
+ Hits          505      508       +3     
- Misses        292      294       +2     
Flag Coverage Δ
unittests 63.34% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PGFPlots.jl 54.50% <50.00%> (-0.04%) ⬇️
src/plots.jl 85.90% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7207ce9...35098e4. Read the comment docs.

@mykelk mykelk merged commit 9fec5b4 into JuliaTeX:master Mar 7, 2022
@mykelk
Copy link
Member

mykelk commented Mar 7, 2022

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legendentry kwarg for BarChart and Scatter
3 participants