Back to \addlegendentry #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mykelk I updated the notebook kernel to Julia 1.5, which I think is the cause of the build failure. I can revert the kernel to 1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently moved from using
\addlegendentryfor legend entries to having a single\legendfiling at the end of all of the plot entries. Unfortunately, this approach does not play well with entries that are not included in the legend, such as when "forget plot" is used.This PR reverts back to using individual
\addlegendentrycalls, but adds in the{}{entry}trick that the previous PR used to guard against commas in an entry.This PR also moves away from === and !== used for
nothingcomparisons in favor ofisnothingand!isnothing.