Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Get PGFPlots.jl working on Julia master #129

Merged
merged 1 commit into from
Dec 22, 2019
Merged

[RFC] Get PGFPlots.jl working on Julia master #129

merged 1 commit into from
Dec 22, 2019

Conversation

DilumAluthge
Copy link
Contributor

This pull request gets PGFPlots.jl working on Julia nightly and Julia master.

@codecov-io
Copy link

codecov-io commented Dec 22, 2019

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #129   +/-   ##
======================================
  Coverage    51.8%   51.8%           
======================================
  Files           4       4           
  Lines         693     693           
======================================
  Hits          359     359           
  Misses        334     334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7198c...463c081. Read the comment docs.

@DilumAluthge DilumAluthge changed the title Get PGFPlots.jl working on Julia master WIP: Get PGFPlots.jl working on Julia master Dec 22, 2019
@mykelk
Copy link
Member

mykelk commented Dec 22, 2019

Thanks for working on this! Let me know when it's ready to merge.

@DilumAluthge DilumAluthge changed the title WIP: Get PGFPlots.jl working on Julia master [RFC] Get PGFPlots.jl working on Julia master Dec 22, 2019
@DilumAluthge
Copy link
Contributor Author

@mykelk This is ready for review now!

@mykelk mykelk merged commit 7b246ed into JuliaTeX:master Dec 22, 2019
@DilumAluthge DilumAluthge deleted the da/fix-on-julia-nightly branch December 22, 2019 23:02
@mykelk
Copy link
Member

mykelk commented Dec 22, 2019

JuliaRegistries/General#7064 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants