Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pairwise multi-threaded and make corkendall and corspearman wrap pairwise. #923

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Make pairwise multi-threaded and make corkendall and corspearman wrap pairwise. #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c85116a
Rewrite pairwise, corkendall and corspearman
PGS62 Mar 30, 2024
8ced336
Delete rankcorrspeedtest.jl
PGS62 Mar 30, 2024
6a8fecd
Partial solution to test failures on Julia 1.0.5
PGS62 Apr 2, 2024
eff32e4
Reverted to using eachcol in the hope that support for Julia 1.0.5 wi…
PGS62 Apr 2, 2024
1a4d064
Deleted commented out tests
PGS62 Apr 2, 2024
893d4b6
Delete settings.json
PGS62 Apr 2, 2024
e2c9ef5
Update pairwise.jl in response to some of devmotion's comments
PGS62 Apr 2, 2024
4c2e7a0
Was calling copytry! too soon. Fixed that.
PGS62 Apr 2, 2024
2119804
Update pairwise.jl
PGS62 Apr 2, 2024
5da5943
nested loops more friendly to Julia being column-major
PGS62 Apr 3, 2024
baf193b
flipped i and j loop variables. reshape -> similar
PGS62 Apr 3, 2024
a1d9ae9
Added iterators EqualSumSubsets and TwoStepRange
PGS62 Apr 4, 2024
951b391
Int64 -> Int to work on 32bit
PGS62 Apr 5, 2024
75d206a
Update tests
PGS62 Apr 5, 2024
56d27cc
Update tests
PGS62 Apr 5, 2024
682859a
Tests now pass on Julia 1.8.5
PGS62 Apr 5, 2024
9c039dd
Compatibility with Julia 1.6
PGS62 Apr 5, 2024
f53b7b5
Test against Julia 1.6, 1.7, 1.8 and 1.9 to find possible new minimum…
PGS62 Apr 5, 2024
88bf8f6
Test on Julia 1.1, 1.2, 1.3. 1.4 and 1.5
PGS62 Apr 5, 2024
ddb1b51
Demonstrate that 1.6 could be new minimum version
PGS62 Apr 5, 2024
f67e867
Corrected call to keyword argument
PGS62 Apr 7, 2024
246f32d
Improved test coverage (src/pairwise.jl#L84-L87)
PGS62 Apr 10, 2024
46d5655
Improved test coverage (StatsBase._cor)
PGS62 Apr 10, 2024
e1395b8
Trivial change to re-run tests
PGS62 Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.0'
- '1.6'
- '1' # automatically expands to the latest stable 1.x release of Julia
- 'nightly'
os:
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Missings = "0.3, 0.4, 1.0"
SortingAlgorithms = "0.3, 1.0"
Statistics = "1"
StatsAPI = "1.2"
julia = "1"
julia = "1.6"

[extras]
BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"
Expand Down
Loading
Loading