Implement Base.allequal and Base.allunique for weight vectors
#894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Sep 25, 2023
src/weights.jl
Outdated
| @@ -313,6 +319,12 @@ length(wv::UnitWeights) = wv.len | |||
| size(wv::UnitWeights) = tuple(length(wv)) | |||
| Base.axes(wv::UnitWeights) = tuple(Base.OneTo(length(wv))) | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/43354 | |||
| if VERSION >= v"1.8.0-DEV.1494" # 98e60ffb11ee431e462b092b48a31a1204bd263d | |||
There was a problem hiding this comment.
Not a big deal at all but it might be nice to combine the two conditionals so that there's only one place that needs editing once we require 1.8 or later.
src/weights.jl
Outdated
| if VERSION >= v"1.8.0-DEV.1494" # 98e60ffb11ee431e462b092b48a31a1204bd263d | ||
| Base.allequal(wv::AbstractWeights) = allequal(wv.values) | ||
| end | ||
| Base.allunique(wv::AbstractWeights) = allunique(wv.values) |
There was a problem hiding this comment.
I agree that allequal would be a good addition but I'm a bit ambivalent about allunique. Doesn't seem bad to have but I can't really think of a situation where it'd be useful. Do you have one in mind?
There was a problem hiding this comment.
No, I don't have a use-case in mind, I think it won't be used a lot. I mainly added it since it complements allequal (and while the fallback would be sufficient, as for allequal, one could potentially benefit if an optimied method exists for weights.values).
ararslan
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose to define
allequalandalluniquefor weight vectors by falling back onallequal(weights.values)andallunique(weights.values)(this means optimizations for types ofweights.valueswill be exploited instead of falling back to the generic iterative algorithm) and implement the optimizations forUnitWeights.In a project I wanted to check
allequal(weights)to avoid an expensive computation for this special case. However, to make this performant forUnitWeightscurrently I have to writeweights isa UnitWeights || allequal(weights).