Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

Add special lifting semantics for isnull() with map() and broadcast() #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nalimilan
Copy link
Member

This is needed to allow isnull.(x) to return something useful.
Currently, the nullable_broadcast_eltype() method is needed since inference
does not work on lifted functions (we need to call it on the original function).

Fixes #180.

@davidagold @johnmyleswhite Cf. our previous discussion at #166 (comment). I think #180 makes it clear we need something like this soon.

This is needed to allow isnull.(x) to return something useful.
Currently, the nullable_broadcast_eltype() method is needed since inference
does not work on lifted functions (we need to call it on the original function).
@codecov-io
Copy link

Codecov Report

Merging #185 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #185     +/-   ##
=========================================
+ Coverage   64.56%   64.86%   +0.3%     
=========================================
  Files          13       13             
  Lines         697      703      +6     
=========================================
+ Hits          450      456      +6     
  Misses        247      247
Impacted Files Coverage Δ
src/map.jl 92% <100%> (+0.69%)
src/broadcast.jl 94.87% <100%> (+0.27%)
src/lift.jl 96.96% <100%> (+0.19%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0dfe02...3f5590b. Read the comment docs.

@nalimilan
Copy link
Member Author

Will merge this week-end if nobody objects.

@nalimilan nalimilan mentioned this pull request May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants