This repository has been archived by the owner on May 4, 2019. It is now read-only.
0.6 fixes #171
Merged
0.6 fixes #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These go though broadcast() now.
This allows accepting BitArrays, which are more frequently returned by broadcast() now.
|
Looks good to me. @ararslan ? |
ararslan
reviewed
Jan 15, 2017
| (:(@compat Base.:.>=), :>=) | ||
| ) | ||
| @eval begin | ||
| ($op)(X::NullableArray, Y::NullableArray) = broadcast($scalar_op, X, Y) |
There was a problem hiding this comment.
Isn't this what's causing the warnings on nightly? For example,
WARNING: .* is no longer a function object; use broadcast(*, ...) instead
There was a problem hiding this comment.
No, it actually comes from the tests which loop other these functions, which is deprecated. I take care of that in the other PR.
There was a problem hiding this comment.
Okay cool, thanks for the explanation!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fixes towards having tests passing again on Julia 0.6. There remains a failure related to
map, which will be fixed by #166.