Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error when formula variables missing from dataset #707

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Conversation

palday
Copy link
Member

@palday palday commented Aug 20, 2023

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

src/linearmixedmodel.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday palday requested review from dmbates and ararslan August 20, 2023 04:10
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (563d465) 95.83% compared to head (03772bc) 95.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          35       35           
  Lines        3263     3266    +3     
=======================================
+ Hits         3127     3130    +3     
  Misses        136      136           
Flag Coverage Δ
current 95.83% <100.00%> (+<0.01%) ⬆️
minimum 95.73% <100.00%> (+<0.01%) ⬆️
nightly 95.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/linearmixedmodel.jl 95.00% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmbates dmbates merged commit c9dbaf6 into main Aug 20, 2023
@dmbates dmbates deleted the pa/errors branch August 20, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants