Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from PIRLS failure by returning finitial #616

Merged
merged 12 commits into from
Aug 9, 2023
Merged

Conversation

palday
Copy link
Member

@palday palday commented May 18, 2022

One potential downside to this approach is that it does make it possible to get stuck and/or have the optimizer believe that the initial values are the optimum. The former should be clear from (lack of) progress. I guess we could check that m.optsum.finitial != objective(m) and error if it does. The downside is that we have try in the objective, which we can assume is a fairly hot function.

  • add tests (achieved by fitting a model that previously didn't work with fast=false)
  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday palday force-pushed the pa/pirls_stability branch from 0f06c3b to 3c97596 Compare May 18, 2022 01:29
@palday palday requested a review from dmbates May 18, 2022 01:30
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c99a2d3) 95.82% compared to head (8cbaadf) 95.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   95.82%   95.83%           
=======================================
  Files          35       35           
  Lines        3259     3263    +4     
=======================================
+ Hits         3123     3127    +4     
  Misses        136      136           
Flag Coverage Δ
current 95.83% <100.00%> (?)
minimum 95.72% <100.00%> (+<0.01%) ⬆️
nightly 95.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/generalizedlinearmixedmodel.jl 90.47% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday merged commit 4833c11 into main Aug 9, 2023
@palday palday deleted the pa/pirls_stability branch August 9, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants