-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix notation in laplace.jl docstring #838
Conversation
I'm fine to keep these conventions (better than being inconsistent), but a great place of knowledge uses |
I am fine with |
Just waiting for another opinion and this is merged, thanks for the contribution! |
(Travis is failing while #836 not merged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Should it be sigma? |
doesn't seem to be the convention for Laplace. |
we should be consistent for all location/scale families:
|
This part will be simpler for the construction with #823, but without it, it may be dangerous to require a parameter which is not the one usually taken |
I’m no sure what you mean? |
I just noticed that cauchy.jl has similar inconsistencies in its docstring. |
I'd be for keeping letters different from |
restarted the build, merging as everything goes green |
@simonbyrne can you restart appveyor here? |
No description provided.