Implemented interface and tests for Studentized Range distribution #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to compromise due to less accuracy and slow computation time.
BioTurboNick
changed the title
|
StatsFuns.jl PR was approved and tagged, tests should pass now. |
|
The required StatsFuns version should be bumped to 0.8.0 |
matbesancon
requested changes
Feb 10, 2019
|
one minor change and it's good to merge for me |
|
thanks @BioTurboNick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on this PR for StatsFuns.jl: JuliaStats/StatsFuns.jl#66
Uses R's functions for cdf and quantile, no pdf implementation. Tests implemented with relaxed matching tolerance (R implementation reports accuracy to only 4th decimal place).