-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding stable distributions #1703
Conversation
Bump. Is there an interest in this? Stable distributions seem an important class for me (depends on the background I guess) and they are provided e.g., in SciPy and Matlab. |
That's nice! I'd definitely find this useful. |
@simsurace I've added tests. I hope there will be someone with will/time to supervise merging it. At least, the "competition" in other languages have this feature. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
- Coverage 85.82% 85.31% -0.51%
==========================================
Files 137 145 +8
Lines 8315 8806 +491
==========================================
+ Hits 7136 7513 +377
- Misses 1179 1293 +114 ☔ View full report in Codecov by Sentry. |
To me everything looks very clean, thanks a lot for the work. However, I don't have merge rights. |
@devmotion are you able to review this, or do you know someone who is able to? |
@devmotion Could I ask for an update on this? Currently I don't know even if this commit fits and may potentially be merged. If there'd be no reasonable horizon on making this public I'd probably change it to a separate package. Sub-optimal I my view, but better than nothing. |
Update: this functionality is currently available using StableDistributions.jl package. |
I just came across this PR in my backlog, sorry 🙂 I'm not strictly against adding new dependencies to Distributions but my general feeling is that the size of Distributions slows down development (and generally I tend to prefer smaller packages as a user since it allows to reduce compilation and load times), so I think it's fine to define distributions outside of Distributions.jl. For users, I think it could be helpful to list such more "official" downstream packages in the docs. The advantage of Distributions, of course, is that potentially - but not always as you can see... - more people are able to check your code and to contribute. Possibly this could be improved by moving some of such downstream packages to JuliaStats - but just moving it there without actually increasing the number of collaborators isn't very helpful either. |
Please be patient, I have zero experience with open source projects.
As for the code:
@quantile_newton Stable
should provide default implementation of cdf inversion, but it does not seem to work when I'm checking on my local version...