-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
**BREAKING** Fix loss of structure in cov() and invcov() of AbstractMvNormal subtypes #1373
base: master
Are you sure you want to change the base?
Conversation
…ypes to dense Matrix
Hi, is there anything that would hold back merging this PR ? @devmotion ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
- Coverage 86.00% 83.88% -2.13%
==========================================
Files 144 144
Lines 8646 7004 -1642
==========================================
- Hits 7436 5875 -1561
+ Misses 1210 1129 -81 ☔ View full report in Codecov by Sentry. |
IMO this is a breaking change and therefore we should make a breaking release. Since people dislike breaking releases of Distributions (#1317), we should check if there are any other breaking changes that could be included in Distributions 0.26. |
I wonder if it is possible to check if/how breaking this would be for downstream packages. Is there actually any package that relies on |
Resolves #572. Distributions.jl has a lower bound of PDMats=0.10, in which PDMat and PDiagMat are subtypes of AbstractMatrix, so no need to call Matrix() anymore.
What, if anything, do I still need to add to this PR to get it merged ?