-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mle for weibull distribution #1342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added some comments and suggestions.
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 82.16% 82.23% +0.06%
==========================================
Files 116 116
Lines 6604 6635 +31
==========================================
+ Hits 5426 5456 +30
- Misses 1178 1179 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, also the formulas seem to be correct 👍 I added two additional minor suggestions.
Co-authored-by: David Widmann <[email protected]>
Thanks a lot! |
I added an implementation that solves for the Weibull maximum likelihood estimators using newtons method. Included some basic tests as sanity checks and updated the docs.
I noticed that there was some discussion in #1267 on whether or not use a generic newtons method and wondering if that's been decided on.
Merging this can close #702.