Add missing LineNumberNode to @swappable call (fixes #257)

[getzdan]

There has been some change to Julia in the macrocall AST, adding the LineNumberNode.
Unless there is another change to Julia, some packages using :macrocall expression generation will break.

[nalimilan]

Thanks. Indeed this fixes loading the package, but I wonder whether the test failure may be related: the path between #= and =# is suspicious.

Booleans: Error During Test
  Expression evaluated to non-Boolean
  Expression: any(#= C:\Users\appveyor\.julia\v0.7\DataArrays\test\booleans.jl:15 =# @data([NA, 1, 2]) .== 1) == true
       Value: NA

[getzdan]

Don't think the test error is related. Actually, it seems to me the test should Fail (but not error), as 1 == NA should be NA. But this discussion is for the other issue.

[nalimilan]

It would be great if you could identify the exact commit which broke this (use contrib/commit-name.sh).

[getzdan]

My guess is the exact commit is: 0.7.0-DEV.328 . Specifically, JuliaLang/julia@fcdf437

[tkelman]

You should use the merge commit JuliaLang/julia@9e3318c. Its master parent commit, JuliaLang/julia@8b2cac4, is 0.7.0-DEV.353 but does not have this change.

[nalimilan]

Damn, everybody gets this wrong at least once. Do you think the script could do this automatically?

[tkelman]

we could maybe have it do some git operations to try to figure out whether the commit it runs on is a merge (or squash merge) commit or something from a PR branch and give a warning, but I'm not sure what to check for

[tkelman]

If github would fix "rebase and merge" to include a reference to the PR number, we could switch to that for multi-commit PR's and disable the normal merge commit option. Single-commit PR's should almost always be squash merged since there's no reason not to, so it's only multi-commit PR's where there's a risk of VERSION getting things wrong.

[tkelman]

did this get fixed?

[nalimilan]

No, but see #264.

[getzdan]

You are right .== is acting weird:

julia> (@data [NA, 1, 2]) .== 1
0-dimensional DataArrays.DataArray{Bool,0}:
NA

[nalimilan]

I guess we can still merge this (after updating the version check) and continue debugging, as it's always easier to debug a package that can be loaded.

[ararslan]

Thanks for figuring this out!

[nalimilan]

The failure actually comes from a change in Base, see JuliaLang/julia#22019 and JuliaLang/julia#22130.