fix findmin/findmax

[Moelf]

fixes JuliaLang/julia#44978

[codecov-commenter]

Codecov Report

Merging #93 (6e80751) into main (f8ffbb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files           7        7           
  Lines        5677     5679    +2     
=======================================
+ Hits         5063     5065    +2     
  Misses        614      614           

Impacted Files	Coverage Δ
src/sparsevector.jl	94.17% <100.00%> (+<0.01%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[Moelf]

Error seems unrelated

[Moelf]

404 error is unrelated

[Moelf]

looks like that logic is flawed

[KristofferC]

@dkarrasch, I didn't realize you did not have merge access here. I think you should have gotten an invite now.

[dkarrasch]

@KristofferC I think I already had merge access, I was just a bit hesitant to push the button. Tests pass, which is good, but I haven't completely understood the originally missing case here.

[KristofferC]

I think I already had merge access

Your approve symbol was gray which I thought typically means that the person reviewing does not have merge rights. It is green now, however.

[Moelf]

The missing case is when the sparse vector is filled with value from the beginning but not all the way to the end.

The original "find first non-stored zero" rely on there existing a gap in the stored values

[dkarrasch]

Thanks for the fix! Now, how do we make sure this enters julia v1.8?

[Moelf]

something like this:

• 🤖 Bump the SparseArrays stdlib from 8d397cc to aa51c9b JuliaLang/julia#44142

[dkarrasch]

Alright, so the bot will jump in at some point.

[Moelf]

idk if the backport to 1.8 will have to be manual though @DilumAluthge

[oscardssmith]

did we ever back port this?

[Moelf]

@DilumAluthge

[github-actions]

The backport to 1.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8 1.8
# Navigate to the new working tree
cd .worktrees/backport-1.8
# Create a new branch
git switch --create backport-93-to-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 352dfafd4a31782c316c6aac69806336b979922c
# Push it to GitHub
git push --set-upstream origin backport-93-to-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8

Then, create a pull request where the base branch is 1.8 and the compare/head branch is backport-93-to-1.8.