Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR: handle xtype/dtype returned from LibSuiteSparse that don't match matrix element type #586

Merged

Conversation

pawel-tarasiuk-quantumz
Copy link
Contributor

LibSuiteSparse methods called from qr! might return structures with dtype that doesn't match the element type of matrix to factorize. This occurs for Tv=Float32 and Julia >=1.11.

Should fix #585

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.07%. Comparing base (9731aef) to head (4206c28).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/solvers/cholmod.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
+ Coverage   84.03%   84.07%   +0.04%     
==========================================
  Files          12       12              
  Lines        9183     9188       +5     
==========================================
+ Hits         7717     7725       +8     
+ Misses       1466     1463       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah merged commit 268d390 into JuliaSparse:main Nov 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken dtype detection in CHOLMOD in 1.11
2 participants