-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for SuiteSparse v7.4.0 #478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 85.57% 85.58% +0.01%
==========================================
Files 12 12
Lines 8832 8832
==========================================
+ Hits 7558 7559 +1
+ Misses 1274 1273 -1 ☔ View full report in Codecov by Sentry. |
Note that now tests are are failing because I bumped the required version of SuiteSparse_jll, which isn't available in Julia yet, so that's expected, but tests were passing on the previous commit (note that macOS job was cancelled just because the job was taking longer than the other OSes, but tests were all successful to that point). However I'd appreciate some help with figuring out this test failure in the julia repository, it only happens on 32-bit Windows: JuliaLang/julia#52577 (comment) |
I think we should at least regenerate the wrappers and see what happens. |
How? 🙂 |
Co-authored-by: Raye Kimmerer <[email protected]>
I included changes in #480, and am now running tests in JuliaLang/julia#52577 based on this PR. If tests are successful I suggest
|
@ViralBShah @rayegun can you please review and merge if/when ready? As a reminder, my suggested plan is outlined at #478 (comment) |
Thanks @giordano. Going forward, we should probably always upgrade the wrappers with every minor version update to SuiteSparse. Even longer term, it would be nice to move all this out of stdlib, although I wonder if upgradable stdlibs will actually make the upgrading experience a bit more pleasant. |
This goes with JuliaLang/julia#52577. All tests are passing, at least for aarch64-apple-darwin (the first platform to have finished running), but there are lots of warnings like
My understanding is that we need to update these version numbers accordingly. I have no idea whether we need to do anything else.
Close #480, fix #482.