Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify calling Aqua #473

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Simplify calling Aqua #473

merged 1 commit into from
Nov 21, 2023

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Nov 16, 2023

This change makes updating Aqua and getting all new functionality as easy as bumping the compat version (for breaking releases).
With the current setup, you don't get any new tests.
Furthermore, we added functionality in Aqua itself to mark certain tests as broken.
Lastly, detect_unbound_args_recursively and Piracies.hunt are purely internal and subject to change in a non-breaking release in the near future.

cc @DilumAluthge

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f154de2) 85.64% compared to head (4073df6) 85.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   85.64%   85.69%   +0.04%     
==========================================
  Files          13       13              
  Lines        8861     8861              
==========================================
+ Hits         7589     7593       +4     
+ Misses       1272     1268       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah merged commit 951837f into JuliaSparse:main Nov 21, 2023
8 checks passed
@lgoettgens lgoettgens deleted the lg/Aqua branch November 21, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants