-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports to Julia v1.10, part 2 #463
Conversation
What's the issue? Is SuiteSparse v7.2.1 not released yet?
|
I think the reason is that on 1.10 the version of SuiteSparse is 7.2.0. It is not clear to me why the compat here need to be bumped though. Is SparseArrays on this branch not compatible with 7.2.1? |
Wait, there was another Generally, I don't know. That's how I understood @ViralBShah, that something needs to be backported to the release branch, without "bumping SparseArrays". But you're right, the compat entry is open to nonbreaking new releases... |
What I meant was that SparseArrays master has a lot more on it than what we need in 1.10. But the whole SuiteSparse dependency is locked down (probably more than it needs to). There is no API change between 7.2 and 7.2.1, but it is possible wrappers need regenerating. |
We should probably remove the Manifest.toml in the gen folder. The julia compat in the main SparseArrays.jl Project.toml on backports should become 1.10 (which is 1.11 on master). |
It is already: Line 14 in d8aae6d
So, do we need to do anything or can we just close this? Will SparseArrays simply pull SuiteSparse v7.2.1 by the compat? |
@KristofferC How should we proceed? |
If we update e.g. the Suitesparse jll on 1.10 SparseArrays.jl should use that. |
Ok - the SuiteSparse_jll bump will have to happen on the Julia stdlib side as part of the backport of my PR. So this one can just be merged here. |
Is the thinking here that bumping the compat here is what upgrades SuiteSparse? If so, that is not the case. I don't see what use this PR has (and now CI fails from it and will keep failing until there is a new 1.10 release). |
Yes, it is to upgrade suitesparse to the release version. If there is a better way to upgrade the suitesparse dependency to 7.2.1 and relax the compat, that would be fine too. |
The version of Julia used for the actions is older than the bump of SuiteSparse to 7.2.1. So, if we can update the Julia version in the actions here (perhaps RC1?), then this CI will start working. |
No description provided.