Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports to Julia v1.10, part 2 #463

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

dkarrasch
Copy link
Member

No description provided.

@dkarrasch
Copy link
Member Author

What's the issue? Is SuiteSparse v7.2.1 not released yet?

possible versions are: 7.2.0 or uninstalled

@KristofferC
Copy link
Member

KristofferC commented Oct 19, 2023

I think the reason is that on 1.10 the version of SuiteSparse is 7.2.0. It is not clear to me why the compat here need to be bumped though. Is SparseArrays on this branch not compatible with 7.2.1?

@dkarrasch
Copy link
Member Author

Wait, there was another Manifest.toml in the gen folder, that had a v7.2.0 hardcoded. Does that need bumping?

Generally, I don't know. That's how I understood @ViralBShah, that something needs to be backported to the release branch, without "bumping SparseArrays". But you're right, the compat entry is open to nonbreaking new releases...

@ViralBShah
Copy link
Member

What I meant was that SparseArrays master has a lot more on it than what we need in 1.10. But the whole SuiteSparse dependency is locked down (probably more than it needs to). There is no API change between 7.2 and 7.2.1, but it is possible wrappers need regenerating.

@ViralBShah
Copy link
Member

ViralBShah commented Oct 19, 2023

We should probably remove the Manifest.toml in the gen folder.

The julia compat in the main SparseArrays.jl Project.toml on backports should become 1.10 (which is 1.11 on master).

@dkarrasch
Copy link
Member Author

The julia compat in the main SparseArrays.jl Project.toml on backports should become 1.10 (which is 1.11 on master).

It is already:

julia = "1.10"

So, do we need to do anything or can we just close this? Will SparseArrays simply pull SuiteSparse v7.2.1 by the compat?

@ViralBShah
Copy link
Member

@KristofferC How should we proceed?

@KristofferC
Copy link
Member

If we update e.g. the Suitesparse jll on 1.10 SparseArrays.jl should use that.

@ViralBShah
Copy link
Member

Ok - the SuiteSparse_jll bump will have to happen on the Julia stdlib side as part of the backport of my PR. So this one can just be merged here.

@ViralBShah ViralBShah merged commit d7cf596 into release-1.10 Oct 19, 2023
1 of 6 checks passed
@ViralBShah ViralBShah deleted the backports-release-1.10 branch October 19, 2023 16:38
@KristofferC
Copy link
Member

Is the thinking here that bumping the compat here is what upgrades SuiteSparse? If so, that is not the case. I don't see what use this PR has (and now CI fails from it and will keep failing until there is a new 1.10 release).

@ViralBShah
Copy link
Member

ViralBShah commented Oct 23, 2023

Yes, it is to upgrade suitesparse to the release version.

If there is a better way to upgrade the suitesparse dependency to 7.2.1 and relax the compat, that would be fine too.

@ViralBShah
Copy link
Member

The version of Julia used for the actions is older than the bump of SuiteSparse to 7.2.1. So, if we can update the Julia version in the actions here (perhaps RC1?), then this CI will start working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants